fix: dates are equal, if both are invalid (#2326)

vitest-dev · Nov 14, 2022 · 30c59f5 · 30c59f5
1 parent a57914f
commit 30c59f5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/vitest/src/integrations/chai/jest-utils.ts b/packages/vitest/src/integrations/chai/jest-utils.ts
@@ -125,8 +125,8 @@ function eq(
     case '[object Date]':
       // Coerce dates to numeric primitive values. Dates are compared by their
       // millisecond representations. Note that invalid dates with millisecond representations
-      // of `NaN` are not equivalent.
-      return +a === +b
+      // of `NaN` are equivalent.
+      return (isNaN(a) && isNaN(b)) || (+a === +b)
     // RegExps are compared by their source patterns and flags.
     case '[object RegExp]':
       return a.source === b.source && a.flags === b.flags

diff --git a/test/core/test/jest-expect.test.ts b/test/core/test/jest-expect.test.ts
@@ -35,6 +35,9 @@ describe('jest-expect', () => {
     expect([{ text: 'Bye' }]).not.toContainEqual({ text: 'Hello' })
     expect(1).toBeGreaterThan(0)
 
+    expect(new Date(0)).toEqual(new Date(0))
+    expect(new Date('inValId')).toEqual(new Date('inValId'))
+
     expect(BigInt(1)).toBeGreaterThan(BigInt(0))
     expect(1).toBeGreaterThan(BigInt(0))
     expect(BigInt(1)).toBeGreaterThan(0)