Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gomod: do not replace GRPC #8416

Merged
merged 1 commit into from Jul 6, 2021
Merged

Conversation

vmg
Copy link
Collaborator

@vmg vmg commented Jul 6, 2021

Description

I landed grpc/grpc-go#4561 in upstream GRPC last week, which fixes a corner-case bug that was breaking our ETCD client. Since 1.39.0 now exists with the bugfix, we no longer need to pin our version of GRPC with a replacement.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Vicent Marti <vmg@strn.cat>
Copy link
Member

@derekperkins derekperkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekperkins derekperkins merged commit 1b15b69 into vitessio:main Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants