Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contour layer for scatterplot #1823

Open
wants to merge 23 commits into
base: keller-mark/case-control-violin-plot
Choose a base branch
from

Conversation

keller-mark
Copy link
Member

@keller-mark keller-mark commented Mar 12, 2024

Fixes #1775

Background

TODO:

  • Option for user to modify or specify the percentiles used for the contour thresholds Support a mean aggregation strategy d3/d3-contour#78
  • Allow to filter points by sample set membership - use stratification hook
  • Option to weight points by the selected gene
  • Option to simultaneously visualize data from multiple sample sets (e.g. with diverging colormap)?
  • Option to use per-cell type contour layers using the cell type colors
    • Need to compute the isoline thresholds ahead of time (prior to cell type stratification?)
  • Coordination type to determine whether contour layer is colored by obsSet vs. sampleSet (vs. static color?)
  • Coordination type to determine whether point layer is visible vs. not
  • Coordination type to determine whether contour layer is visible vs. not
  • Coordination type to determine whether contours are filled vs. not (and support in the layer)
  • Option for user to manually define opacity values corresponding to each threshold/percentile?
  • Option to use colormapRange cutoffs when calculating weights
  • Tests for stratifyArrays utility?
  • Playwright visual test for contour features?
  • Is subclassing of ContourLayer still needed?

Resources

Change List

Checklist

  • Ensure PR works with all demos on the dev.vitessce.io homepage
  • Open (draft) PR's into vitessce-python and vitessce-r if this is a release PR
  • Documentation added or updated

Copy link
Contributor

github-actions bot commented Mar 14, 2024

Size Change: 0 B

Total Size: 6.43 MB

ℹ️ View Unchanged
Filename Size
./packages/main/prod/dist/blosc-********.js 612 kB
./packages/main/prod/dist/browser-********.js 16.2 kB
./packages/main/prod/dist/chunk-INHXZS53-********.js 558 B
./packages/main/prod/dist/deflate-********.js 244 B
./packages/main/prod/dist/gzip-********.js 693 B
./packages/main/prod/dist/hglib-********.js 4.33 MB
./packages/main/prod/dist/index-********.js 459 kB
./packages/main/prod/dist/index.min.js 927 B
./packages/main/prod/dist/jpeg-********.js 15.3 kB
./packages/main/prod/dist/lerc-********.js 47.2 kB
./packages/main/prod/dist/lz4-********.js 43.9 kB
./packages/main/prod/dist/lzw-********.js 2.11 kB
./packages/main/prod/dist/packbits-********.js 577 B
./packages/main/prod/dist/pako.esm-********.js 68.6 kB
./packages/main/prod/dist/raw-********.js 169 B
./packages/main/prod/dist/troika-three-text.esm-********.js 182 kB
./packages/main/prod/dist/webimage-********.js 837 B
./packages/main/prod/dist/zlib-********.js 695 B
./packages/main/prod/dist/zstd-********.js 643 kB

compressed-size-action

@keller-mark keller-mark marked this pull request as ready for review May 31, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant