Dot plot #1383
Open
Dot plot #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilan-gold
reviewed
Mar 13, 2023
| @@ -35,7 +35,7 @@ export function FeatureListSubscriber(props) { | |||
| variablesLabelOverride, | |||
| theme, | |||
| title: titleOverride, | |||
| enableMultiSelect = false, | |||
| enableMultiSelect = true, | |||
There was a problem hiding this comment.
I am not sure this is working?
There was a problem hiding this comment.
Also, this is a pretty big default change, no?
| /** | ||
| * Get expression data for the cells | ||
| * in the selected cell sets. | ||
| * @param {object} expressionMatrix |
There was a problem hiding this comment.
For the given gene selection, and also it doesn't have the rows and cols I think.
| mergedCellSets, cellSetSelection, cellIndices, | ||
| ); | ||
| geneSelection.forEach((featureName, featureI) => { | ||
| const featureKey = uuidv4(); |
There was a problem hiding this comment.
Is this for duplicated gene names?
Comment on lines
+49
to
+70
| // Get the max characters in an axis label for autsizing the bottom margin. | ||
| const maxCharactersForGroup = data.reduce((acc, val) => { | ||
| // eslint-disable-next-line no-param-reassign | ||
| acc = acc === undefined || val.group.length > acc ? val.group.length : acc; | ||
| return acc; | ||
| }, 0); | ||
| const maxCharactersForFeature = data.reduce((acc, val) => { | ||
| // eslint-disable-next-line no-param-reassign | ||
| acc = acc === undefined || val.feature.length > acc ? val.feature.length : acc; | ||
| return acc; | ||
| }, 0); | ||
| // Use a square-root term because the angle of the labels is 45 degrees (see below) | ||
| // so the perpendicular distance to the bottom of the labels is proportional to the | ||
| // square root of the length of the labels along the imaginary hypotenuse. | ||
| // 30 is an estimate of the pixel size of a given character and seems to work well. | ||
| const autoMarginVertical = marginBottom | ||
| || 30 + Math.sqrt(maxCharactersForFeature / 2) * 30; | ||
| const autoMarginHorizontal = marginRight | ||
| || 30 + Math.sqrt(maxCharactersForGroup / 2) * 30; | ||
|
|
||
| const plotWidth = clamp(width - autoMarginHorizontal - 120, 10, Infinity); | ||
| const plotHeight = clamp(height - autoMarginVertical, 10, Infinity); |
There was a problem hiding this comment.
This trick is used elsewhere, no? Should it refactored into its own hook or function?
|
Ah, right, also the "full" setting of the slider should produce an empty plot? Not one with evenly sized dots? |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #754
Fixes #1040
TODO
posThresholdChecklist
vitessce-pythonandvitessce-rif this is a release PR