Skip to content

Commit

Permalink
Use es2019 in vite config (#1553)
Browse files Browse the repository at this point in the history
* Use es2019 in vite config

* Update README
  • Loading branch information
keller-mark committed May 31, 2023
1 parent 4f5ef0e commit 4f80119
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -65,6 +65,7 @@
- Added a new prop to `FeatureListSubscriber` to read in `showTable`, having it false by default.
- Modified the `FeatureList` component to pass in 2 columns and 2 column labels if `showTable` is true, otherwise just 1 column and 1 columnLabel if `showTable` is false.
- Modified the `SelectableTable` component and the table styles to handle showing 2 cells per row.
- Use `es2019` in Vite bundle targets for `packages/main/prod` and `packages/main/dev` to support HuBMAP portal-ui.
- Changes in `ToolMenu`:
- Added a new button that calls `onRecenterButtonCLick` function on click.
- Added css for the new button and introduced differentiation between a button and a tool.
Expand Down
22 changes: 21 additions & 1 deletion consumer/README.md
Expand Up @@ -26,4 +26,24 @@ Related directories/files:
- `pages/`
- `next.config.js`

Open http://localhost:3003/consumer/out/index.html
Open http://localhost:3003/consumer/out/index.html


## How to test in portal-ui

Instructions as of 5/26/2023 (commit hash [hubmapconsortium/portal-ui#fc8a881f](https://github.com/hubmapconsortium/portal-ui/commit/fc8a881ff6f793b4a0dbbeed60f2186fe9d880c4))

```sh
pnpm run build
pnpm run bundle
./scripts/consumer-install.sh

cd ../portal-ui/context
npm install

# comment out `npm install` line in ./etc/dev/dev-start.sh

npm install $(ls ../../vitessce/consumer/vitessce-*.tgz)
cd ..
./etc/dev/dev-start.sh # open http://localhost:5001
```
1 change: 1 addition & 0 deletions packages/main/dev/vite.config.js
Expand Up @@ -14,6 +14,7 @@ export default defineConfig({
emptyOutDir: false,
minify: isProduction ? 'esbuild' : false,
sourcemap: false,
target: 'es2019', // portal-ui cannot handle the nullish coalescing output by ESNext
lib: {
entry: resolve(__dirname, 'src/index.js'),
name: 'vitessce',
Expand Down
1 change: 1 addition & 0 deletions packages/main/prod/vite.config.js
Expand Up @@ -15,6 +15,7 @@ export default defineConfig({
emptyOutDir: false,
minify: isProduction ? 'esbuild' : false,
sourcemap: false,
target: 'es2019', // portal-ui cannot handle the nullish coalescing output by ESNext
lib: {
entry: resolve(__dirname, 'src/index.js'),
name: 'vitessce',
Expand Down

0 comments on commit 4f80119

Please sign in to comment.