(chore): Clean up AnnDataWrapper API
#341
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I agree it may not be the nicest API, without more context/motivation, I don't think there is enough to justify this breaking change, as it will break existing docs/reference materials, Vitessce config generation code in |
|
@keller-mark This is motivated by #333. We could just keep the non-outward-facing changes so that when the |
ilan-gold
commented
May 16, 2024
Comment on lines
+10
to
+19
| # Ignore line too long | ||
| E501, | ||
| # Ignore invalid escape sequence '\*' | ||
| W605, | ||
| # Ignore line break before binary operator: Skim down the left edge to understand intent. | ||
| W503, | ||
| # Ignore continuation line over-indented for visual indent | ||
| E127 | ||
| # Ignore continuation line under-indented for visual indent | ||
| E128 |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open to other options here, but basically I did two things.
adata_XXX->base_XXXsince the semantics are a bit more general and I thinkadatais redundant anywaypath->elemsince I thinkelemis a bit nicer andpathcan refer to a sub-URL which is kind of a path, but also not really.This is definitely a breaking change, so I'm going to try to finish up other PRs that are also breaking at the same time, like our python support.