Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commits #330

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

pre-commits #330

wants to merge 7 commits into from

Conversation

giovp
Copy link

@giovp giovp commented Apr 2, 2024 •
edited

starting with adding pre-commits checks from scverse defaults if useful, consider also using https://results.pre-commit.ci/ for CI linting, feel free to close @ilan-gold

@giovp giovp marked this pull request as draft April 2, 2024 16:18
@ilan-gold ilan-gold requested a review from keller-mark May 7, 2024 15:13
@ilan-gold
Copy link
Collaborator

@keller-mark I like the changes ruff made vs. autopep8 / flake and pre-commit runs automatically including backfilling with commits. Feel free to close if you just want to keep things as-is

@ilan-gold ilan-gold marked this pull request as ready for review May 7, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keller-mark keller-mark Awaiting requested review from keller-mark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@giovp @ilan-gold