fix: don't escape dash in define regex

packages/vite/src/node/plugins/define.ts

@@ -80,7 +80,7 @@ export function definePlugin(config: ResolvedConfig): Plugin {
           '(?<![\\p{L}\\p{N}_$]|(?<!\\.\\.)\\.)(' +
             replacementsKeys
               .map((str) => {
-                return str.replace(/[-[\]/{}()*+?.\\^$|]/g, '\\$&')
+                return str.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')
               })
               .join('|') +
             // Mustn't be followed by a char that can be part of an identifier

playground/define/__tests__/define.spec.ts

@@ -1,6 +1,6 @@
 import { expect, test } from 'vitest'
 import viteConfig from '../vite.config'
-import { page } from '~utils'
+import { isBuild, page } from '~utils'
 
 test('string', async () => {
   const defines = viteConfig.define
@@ -44,4 +44,11 @@ test('string', async () => {
   expect(await page.textContent('.define-in-dep')).toBe(
     defines.__STRINGIFIED_OBJ__
   )
+
+  // only possible through text replacement in build mode, not with global vars in dev (client/env.ts)
+  if (isBuild) {
+    expect(await page.textContent('.key-includes-dash')).toBe(
+      String(defines['KEY-INCLUDES-DASH'])
+    )
+  }
 })

playground/define/index.html

@@ -17,6 +17,7 @@ <h1>Define</h1>
 <p>define variable in html: <code class="exp-define">__EXP__</code></p>
 <p>import json: <code class="import-json"></code></p>
 <p>define in dep: <code class="define-in-dep"></code></p>
+<p>key includes dash: <code class="key-includes-dash"></code></p>
 
 <script type="module">
   const __VAR_NAME__ = true // ensure define doesn't replace var name
@@ -54,6 +55,8 @@ <h1>Define</h1>
 
   import { defined } from 'dep'
   text('.define-in-dep', JSON.stringify(defined))
+
+  text('.key-includes-dash', 'KEY-INCLUDES-DASH')
 </script>
 
 <style>

playground/define/vite.config.js

@@ -20,6 +20,7 @@ module.exports = {
     $DOLLAR: 456,
     ÖUNICODE_LETTERɵ: 789,
     __VAR_NAME__: false,
-    __STRINGIFIED_OBJ__: JSON.stringify({ foo: true })
+    __STRINGIFIED_OBJ__: JSON.stringify({ foo: true }),
+    'KEY-INCLUDES-DASH': true
   }
 }