Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-plugin): support for external .ts files #9736

Closed
wants to merge 3 commits into from
Closed

fix(react-plugin): support for external .ts files #9736

wants to merge 3 commits into from

Conversation

zoy-l
Copy link

@zoy-l zoy-l commented Aug 18, 2022

Description

If an external file creates a component through React.createElement, the compilation will report an error, the ts rule cannot be recognized

Interestingly, version 1.3.2 supports it because of wrong regex match 馃槀

Additional context

demo


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes vitejs/vite#123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@zoy-l zoy-l closed this by deleting the head repository Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite build fails when library has React code in a ".ts" file
1 participant