Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use browser field if likely esm (fixes #9652) #9653

Merged
merged 4 commits into from
Aug 12, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 12, 2022

Description

This PR reverts #9459 and uses a different approach to fix #9445.

browser field
content
pre-#9459 #9459 this PR
UMD use module field use module field use module field
CJS use module field use module field use module field
IIFE (#9652) resolve from mainFields
(default contains module field)
browser field module field
ESM (#9445) resolve from mainFields
(default contains module field)
browser field browser field
undetermined resolve from mainFields
(default contains module field)
browser field module field

undetermined does not include module.exports or import/export.

fixes #9652

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p2-edge-case Bug, but has workaround or limited in scope (priority) regression The issue only appears after a new release labels Aug 12, 2022
@sapphi-red sapphi-red changed the title fix: use browser field if likely esm fix: use browser field if likely esm (fixes #9652) Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-edge-case Bug, but has workaround or limited in scope (priority) regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite v3.0.6 failed to bundle fluent-vue Unable to build or serve application that imports @aws/sdk packages
2 participants