Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid errors when loading the overlay code in workers #9064

Merged
merged 2 commits into from Jul 15, 2022
Merged

fix: avoid errors when loading the overlay code in workers #9064

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bbeec2
Avoid errors when loading the overlay code in workers.
lgarron Jul 13, 2022
4c4260e
chore: format
patak-dev Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/vite/src/client/overlay.ts
View file
Open in desktop
Expand Up @@ -115,6 +115,9 @@ code {
const fileRE = /(?:[a-zA-Z]:\\|\/).*?:\d+:\d+/g
const codeframeRE = /^(?:>?\s+\d+\s+\|.*|\s+\|\s*\^.*)\r?\n/gm

// Allow `ErrorOverlay` to extend `HTMLElement` even in environments where
// `HTMLElement` was not originally defined.
const { HTMLElement = class {} } = globalThis
export class ErrorOverlay extends HTMLElement {
root: ShadowRoot

Expand Down Expand Up @@ -184,6 +187,7 @@ export class ErrorOverlay extends HTMLElement {
}

export const overlayId = 'vite-error-overlay'
const { customElements } = globalThis // Ensure `customElements` is defined before the next line.
if (customElements && !customElements.get(overlayId)) {
customElements.define(overlayId, ErrorOverlay)
}