Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove ?used inject in glob plugin #8900

Merged
merged 4 commits into from Jul 3, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jul 3, 2022

Description

This code was added by antfu/vite-plugin-glob@00a82b7.
But it is not needed because ?used is injected by import-analysis which runs at the end.

Additional context

To fix_ #8245, import-analysis-build needs to resolve id before deciding to inject ?used.
This PR is needed to dedupe that logic.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Jul 3, 2022
@netlify
Copy link

netlify bot commented Jul 3, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 62d773a
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62c1c2e54d35e50009b5eeec

@sapphi-red sapphi-red changed the title refactor: remove used inject refactor: remove ?used inject in glob plugin Jul 3, 2022
playground/test-utils.ts Outdated Show resolved Hide resolved
@patak-dev patak-dev merged commit f9b5c14 into vitejs:main Jul 3, 2022
@sapphi-red sapphi-red deleted the refactor/glob-import-css branch July 3, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants