Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: HMR Break when using context in react templates - Issues: #3301 and #2624 #8329

Closed
wants to merge 1 commit into from
Closed

fix: HMR Break when using context in react templates - Issues: #3301 and #2624 #8329

wants to merge 1 commit into from

Commits on May 25, 2022

  1. Fix React Template For HMR Break With Context 

    When using `createContext` and wrap elements with `context.provided`, hmr breaks and the context tries to access disposed object.

This code avoid the problem by creating one react root per model, and it makes loading page faster too.
    @adnanalbeda
    adnanalbeda committed May 25, 2022
    Configuration menu
    Copy the full SHA
    7b087c3 View commit details
    Browse the repository at this point in the history