Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EPERM error on Windows when processing dependencies #8235

Merged
merged 4 commits into from May 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/vite/src/node/optimizer/index.ts
Expand Up @@ -15,6 +15,7 @@ import {
lookupFile,
normalizeId,
normalizePath,
removeDir,
removeDirSync,
renameDir,
writeFile
Expand Down Expand Up @@ -534,7 +535,7 @@ export async function runOptimizeDeps(
async function commitProcessingDepsCacheSync() {
// Processing is done, we can now replace the depsCacheDir with processingCacheDir
// Rewire the file paths from the temporal processing dir to the final deps cache dir
removeDirSync(depsCacheDir)
await removeDir(depsCacheDir)
await renameDir(processingCacheDir, depsCacheDir)
}

Expand Down
35 changes: 35 additions & 0 deletions packages/vite/src/node/utils.ts
Expand Up @@ -534,6 +534,9 @@ export function removeDirSync(dir: string) {
}
}

export const removeDir = isWindows
? promisify(gracefulRemoveDir)
: removeDirSync
export const renameDir = isWindows ? promisify(gracefulRename) : fs.renameSync

export function ensureWatchedFile(
Expand Down Expand Up @@ -815,6 +818,38 @@ function gracefulRename(
})
}

const GRACEFUL_REMOVE_DIR_TIMEOUT = 5000
function gracefulRemoveDir(
dir: string,
cb: (error: NodeJS.ErrnoException | null) => void
) {
const rmdir = fs.rm ?? fs.rmdir // TODO: Remove after support for Node 12 is dropped
const start = Date.now()
let backoff = 0
rmdir(dir, { recursive: true }, function CB(er) {
if (er) {
if (
(er.code === 'ENOTEMPTY' ||
er.code === 'EACCES' ||
er.code === 'EPERM') &&
Date.now() - start < GRACEFUL_REMOVE_DIR_TIMEOUT
) {
setTimeout(function () {
rmdir(dir, { recursive: true }, CB)
}, backoff)
if (backoff < 100) backoff += 10
return
}

if (er.code === 'ENOENT') {
er = null
}
}

if (cb) cb(er)
})
}

export function emptyCssComments(raw: string) {
return raw.replace(multilineCommentsRE, (s) => ' '.repeat(s.length))
}