Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use esno to replace ts-node #8162

Merged
merged 12 commits into from May 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/renovate.json5
Expand Up @@ -16,7 +16,6 @@
"esbuild",
"rollup",
"node",
"ts-node",
"typescript",

// breaking changes
Expand Down
1 change: 1 addition & 0 deletions .npmrc
Expand Up @@ -4,3 +4,4 @@ hoist-pattern[]=@emotion/*
hoist-pattern[]=postcss
hoist-pattern[]=pug
hoist-pattern[]=source-map-support
hoist-pattern[]=ts-node
8 changes: 4 additions & 4 deletions package.json
Expand Up @@ -28,8 +28,8 @@
"docs-serve": "vitepress serve docs",
"build": "pnpm -r --filter=./packages/* run build",
"dev": "pnpm -r --parallel --filter=./packages/* run dev",
"release": "ts-node scripts/release.ts",
"ci-publish": "ts-node scripts/publishCI.ts",
"release": "esno scripts/release.ts",
"ci-publish": "esno scripts/publishCI.ts",
"ci-docs": "run-s build docs-build"
},
"devDependencies": {
Expand Down Expand Up @@ -64,6 +64,7 @@
"eslint-define-config": "^1.4.0",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-node": "^11.1.0",
"esno": "^0.16.3",
"execa": "^5.1.1",
"fs-extra": "^10.1.0",
"kill-port": "^1.6.1",
Expand All @@ -81,7 +82,6 @@
"semver": "^7.3.7",
"simple-git-hooks": "^2.7.0",
"sirv": "^2.0.2",
"ts-node": "^10.7.0",
"tslib": "^2.4.0",
"typescript": "^4.6.4",
"unbuild": "^0.7.4",
Expand All @@ -92,7 +92,7 @@
},
"simple-git-hooks": {
"pre-commit": "pnpm exec lint-staged --concurrent false",
"commit-msg": "pnpm exec ts-node scripts/verifyCommit.ts $1"
"commit-msg": "pnpm exec esno scripts/verifyCommit.ts $1"
},
"lint-staged": {
"*": [
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-legacy/package.json
Expand Up @@ -19,7 +19,7 @@
"scripts": {
"dev": "unbuild --stub",
"build": "unbuild && pnpm run patch-cjs",
"patch-cjs": "ts-node ../../scripts/patchCJS.ts",
"patch-cjs": "esno ../../scripts/patchCJS.ts",
"prepublishOnly": "npm run build"
},
"engines": {
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-react/package.json
Expand Up @@ -23,7 +23,7 @@
"scripts": {
"dev": "unbuild --stub",
"build": "unbuild && pnpm run patch-cjs",
"patch-cjs": "ts-node ../../scripts/patchCJS.ts",
"patch-cjs": "esno ../../scripts/patchCJS.ts",
"prepublishOnly": "npm run build"
},
"engines": {
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-vue-jsx/package.json
Expand Up @@ -19,7 +19,7 @@
"scripts": {
"dev": "unbuild --stub",
"build": "unbuild && pnpm run patch-cjs",
"patch-cjs": "ts-node ../../scripts/patchCJS.ts",
"patch-cjs": "esno ../../scripts/patchCJS.ts",
"prepublishOnly": "npm run build"
},
"engines": {
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-vue/package.json
Expand Up @@ -19,7 +19,7 @@
"scripts": {
"dev": "unbuild --stub",
"build": "unbuild && pnpm run patch-cjs",
"patch-cjs": "ts-node ../../scripts/patchCJS.ts",
"patch-cjs": "esno ../../scripts/patchCJS.ts",
"prepublishOnly": "npm run build"
},
"engines": {
Expand Down
8 changes: 3 additions & 5 deletions packages/vite/scripts/patchTypes.ts
Expand Up @@ -7,11 +7,9 @@ import type { File } from '@babel/types'
import colors from 'picocolors'
import MagicString from 'magic-string'

// @ts-ignore
const __dirname = resolve(fileURLToPath(import.meta.url), '..')

const tempDir = resolve(__dirname, '../temp/node')
const typesDir = resolve(__dirname, '../types')
const dir = dirname(fileURLToPath(import.meta.url))
const tempDir = resolve(dir, '../temp/node')
const typesDir = resolve(dir, '../types')

// walk through the temp dts dir, find all import/export of types/*
// and rewrite them into relative imports - so that api-extractor actually
Expand Down
48 changes: 16 additions & 32 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions scripts/patchCJS.ts
Expand Up @@ -17,7 +17,7 @@ module.exports.parseVueRequest = parseVueRequest;
*/

import { readFileSync, writeFileSync } from 'fs'
import { bold, red } from 'picocolors'
import colors from 'picocolors'
Shinigami92 marked this conversation as resolved.
Show resolved Hide resolved

const indexPath = 'dist/index.cjs'
let code = readFileSync(indexPath, 'utf-8')
Expand All @@ -40,7 +40,7 @@ if (matchMixed) {

writeFileSync(indexPath, lines.join('\n'))

console.log(bold(`${indexPath} CJS patched`))
console.log(colors.bold(`${indexPath} CJS patched`))
process.exit()
}

Expand All @@ -49,9 +49,9 @@ const matchDefault = code.match(/\nmodule.exports = (\w+);/)
if (matchDefault) {
code += `module.exports["default"] = ${matchDefault[1]};\n`
writeFileSync(indexPath, code)
console.log(bold(`${indexPath} CJS patched`))
console.log(colors.bold(`${indexPath} CJS patched`))
process.exit()
}

console.error(red(`${indexPath} CJS patch failed`))
console.error(colors.red(`${indexPath} CJS patch failed`))
process.exit(1)