Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix jest windows node 18 #7868

Closed
wants to merge 10 commits into from
Closed

ci: fix jest windows node 18 #7868

wants to merge 10 commits into from

Conversation

Shinigami92
Copy link
Member

Description

Related to #7812 (comment)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 self-assigned this Apr 22, 2022
@Shinigami92 Shinigami92 changed the base branch from main to node-18 April 22, 2022 15:13
@Shinigami92 Shinigami92 changed the title build: upgrade to node 18 ci: fix jest windows node 18 Apr 22, 2022
@Shinigami92
Copy link
Member Author

@sodatea seems not to work 🤔

Base automatically changed from node-18 to main April 22, 2022 19:20
@sodatea
Copy link
Member

sodatea commented May 5, 2022

🤔 I tried both the main branch and this PR on a Windows machine, neither can reproduce the error…

@Shinigami92
Copy link
Member Author

https://github.com/vitejs/vite/runs/6322104663?check_suite_focus=true#step:11:286

@sodatea so it's a GitHub Actions bug?
I removed the jest change and brought the PR to newest main, still occurs 😕
Sadly I don't have windows and cannot run it myself to e.g. debug it.

This was referenced May 13, 2022
@sapphi-red sapphi-red deleted the fix-node-18-windows branch October 10, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants