Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): hoist charset #7678

Merged
merged 1 commit into from
Apr 11, 2022
Merged

fix(css): hoist charset #7678

merged 1 commit into from
Apr 11, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 11, 2022

Description

Fixes #6333

Hoist the first @charset found to the top of the css file

Additional context

There could theoretically be two or more charsets in the file, and possibly with different values, but this doesn't seem to be an issue in the past so in this PR we try to suppress the minification warning from esbuild only.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Apr 11, 2022
@patak-dev patak-dev merged commit 29e622c into vitejs:main Apr 11, 2022
@bluwy bluwy deleted the hoist-postcss-charset branch April 11, 2022 18:21
@bluwy bluwy mentioned this pull request Apr 12, 2022
9 tasks
@evanw
Copy link

evanw commented May 29, 2022

In case it's helpful: with the latest release of esbuild, you can now instruct esbuild to silence this warning using this configuration option: logOverride: { 'invalid-@charset': 'silent' }.

@patak-dev
Copy link
Member

Thanks for the heads up @evanw. We'll evaluate if it is better to stop auto-fixing invalid charset for Vite users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warning: "@charset" must be the first rule in the file (2.6.x regression ?)
3 participants