Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(backend-integration): update import for modulepreload polyfill #6507

Closed
wants to merge 1 commit into from

Conversation

katsu223
Copy link

Description

The issue is described here - #4786

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Niputi Niputi added the documentation Improvements or additions to documentation label Jan 14, 2022
@ygj6
Copy link
Member

ygj6 commented Jan 15, 2022

From #4786 (comment), this approach is problematic in TS, no?

@katsu223
Copy link
Author

@ygj6 no, TS/ts-lint just complaining about imports/etc. The issue is also reproducible on react w/o TS.
Here is the reproduction of this: https://codesandbox.io/s/5hgsj?file=/src/main.jsx
Polyfill was imported in main.jsx in order not to simulate backend. To see the error you just need to open sandbox's little browser window in new tab and open console. If the html would be rendered via backend, there would be nothing on the screen

@ygj6
Copy link
Member

ygj6 commented Jan 18, 2022

no, TS/ts-lint just complaining about imports/etc.

@katsu223 Apologise for my misleading review, I was talking about complaints from TS/ts-lint. It does fix the problem, but it also prompts the type error in TS. Not sure if this is a good solution.

@katsu223
Copy link
Author

@ygj6, thanks for clarifications. I am not good at typescript, but I will try to dive into the problem and find the solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants