Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(env-and-mode): add override rule for the env #6304

Merged
merged 6 commits into from Dec 31, 2021
Merged

docs(env-and-mode): add override rule for the env #6304

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
06ac554
docs(env-and-mode): add override rule for the env
poyoho Dec 29, 2021
3b94325
fix: docs
poyoho Dec 29, 2021
04cf8d9
fix: docs with vue-cli
poyoho Dec 31, 2021
7a862c3
chore: format
poyoho Dec 31, 2021
278848b
chore: beautify
poyoho Dec 31, 2021
3c9a79a
chore: beautify
poyoho Dec 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/guide/env-and-mode.md
View file
Open in desktop
Expand Up @@ -24,7 +24,7 @@ It will also replace these strings appearing in JavaScript strings and Vue templ

## `.env` Files

Vite uses [dotenv](https://github.com/motdotla/dotenv) to load additional environment variables from the following files in your [environment directory](/config/#envdir):
Vite uses [dotenv](https://github.com/motdotla/dotenv) to load additional environment variables from the following files in your [environment directory](/config/#envdir) (if define the same variables will override variables in the following reverse order):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it reads hard 🤔
Maybe better something like this? Could even be written better.

Suggested change
Vite uses [dotenv](https://github.com/motdotla/dotenv) to load additional environment variables from the following files in your [environment directory](/config/#envdir) (if define the same variables will override variables in the following reverse order):
Vite uses [dotenv](https://github.com/motdotla/dotenv) to load additional environment variables from the following files in your [environment directory](/config/#envdir) (if they define the same variable, the variable defined in the most specific file will win):

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think .env.${mode}.local is in the most specific, but it will be overwrite 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in not the most specific will win?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the most specific currently don't win, then IMO this is a bug and should be changed
And I assume this is what #6306 is fixing 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check https://cli.vuejs.org/guide/mode-and-env.html#environment-variables, see green alert with title Env Loading Priorities


```
.env # loaded in all cases
Expand Down