Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-legacy): Restore guessable polyfill id (fix #6097) #6208

Closed
wants to merge 1 commit into from

Conversation

StefSchenkelaars
Copy link

Description

The name of the polyfill file is determined by a hardcoded string.
Some packages based on this plugin rely on this predefined name.
This name was changed in 3127219
to prevent resolving files which don't exist. This commit changes
that behaviour to restore the predefined name.

Closes #6097

Additional context

I wanted to write a proper test for this but I wasn't sure where to put this. So if anyone can give me some guidelines I could spend some time on that.

Next to this, we are a bit doubting if this was a typo or an intended change as discussed in ElMassimo/vite_ruby#156 and nystudio107/craft-vite#20.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

The name of the polyfill file is determined by a hardcoded string.
Some packages based on this plugin rely on this predefined name.
This name was changed in 3127219
to prevent resolving files which don't exist. This commit changes
that behaviour to restore the predefined name.
@StefSchenkelaars
Copy link
Author

Closed in favor of #6225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in @vitejs/plugin-legacy breaks manifest.json path to vite/legacy-polyfills
1 participant