Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pregenerate https certificate #6173

Closed
wants to merge 2 commits into from

Commits on Dec 18, 2021

  1. fix: pregenerate https certificate

    node-forge used inside selfsigned is a bit package https://packagephobia.com/result?p=node-forge
    Sadly there is no js-only alternative (only `openssl` wrappers).
    
    While testing this feature (server.https: true) I found chrome detects
    the certificate is insecure though still allows to access the page with
    https after proceeding warning wall.
    
    So as there is not much value in using so big dependency to generate
    insecure certificates @patak-dev got an idea to pregenerate single
    certificate and publish it with vite.
    
    This need to be tested on various machines though before releasing.
    
    I made the certificate expire in 10 years. Let's cross our fingers this
    will be enough.
    
    ```
    du -ck dist/node
    ```
    before: 12348
    after: 9812
    TrySound committed Dec 18, 2021
    Copy the full SHA
    acdab15 View commit details
    Browse the repository at this point in the history
  2. Fix script with ts

    TrySound committed Dec 18, 2021
    Copy the full SHA
    5f5209d View commit details
    Browse the repository at this point in the history