fix: isBuiltin using patched native builtinModules

[Niputi]

Description

fix: #5826

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[Niputi]

• moved generation of list out of the function
• removed adding old modules as wanted from Sodatea

[Niputi]

looks like some node 12 tests expect fs/promises present

[ygj6]

looks like some node 12 tests expect fs/promises present

@Niputi Was the failed test created in #5248? I think it shows a clue as to why we need to count the missing built-in modules, which will solve problems like this and #4037

[patak-dev]

I'm also not sure that what I said here isn't an issue: #5827 (comment).

For the beta, maybe we could go with the full harcoded list (or compute it by patching builtinModules, but making sure we have everything). We can use a set as suggested by Shini

const builtins = new Set([
  ...builtinModules,
  'fs/promises',
  // and others...
])

Later we can research with more time if it is safe to only use builtinModules (that looking at the linked issues, doesn't seems to be the case)

[sodatea]

Yeah, the safe option, for now, is to use a hard-coded list + ...builtinModules so that it works with Node.js v12 to any future versions.

We can revisit it later in 2.8 or 3.0 to see if the edge case that "compiling using node v12 code to be run in node v16 in the server" is what we intend to support.
Let's add a TODO comment in the relevant code.

[patak-dev]

For reference, it looks like @rollup/plugin-node-resolve directly uses node builtins
https://github.com/rollup/plugins/blob/02fb349d315f0ffc55970fba5de20e23f8ead881/packages/node-resolve/src/index.js#L14
We aren't using this plugin though, just another bit of info for when we analyze changing Vite later.

[willonzxy]

hello 我是伟龙。已收到您的邮件，这是来自QQ邮箱的假期自动回复邮件，请勿回复。