fix: scoped variable with array destructuring & nested arguments

packages/vite/src/node/ssr/__tests__/ssrTransform.spec.ts

@@ -188,6 +188,48 @@ test('do not rewrite when variable is in scope', async () => {
   expect(result.deps).toEqual(['vue'])
 })
 
+// #5472
+test('do not rewrite when variable is in scope with object destructuring', async () => {
+  const result = await ssrTransform(
+    `import { fn } from 'vue';function A(){ let {fn, test} = {fn: 'foo', test: 'bar'}; return { fn }; }`,
+    null,
+    null
+  )
+  expect(result.code).toMatchInlineSnapshot(`
+    "const __vite_ssr_import_0__ = await __vite_ssr_import__(\\"vue\\");
+    function A(){ let {fn, test} = {fn: 'foo', test: 'bar'}; return { fn }; }"
+  `)
+  expect(result.deps).toEqual(['vue'])
+})
+
+// #5472
+test('do not rewrite when variable is in scope with array destructuring', async () => {
+  const result = await ssrTransform(
+    `import { fn } from 'vue';function A(){ let [fn, test] = ['foo', 'bar']; return { fn }; }`,
+    null,
+    null
+  )
+  expect(result.code).toMatchInlineSnapshot(`
+    "const __vite_ssr_import_0__ = await __vite_ssr_import__(\\"vue\\");
+    function A(){ let [fn, test] = ['foo', 'bar']; return { fn }; }"
+  `)
+  expect(result.deps).toEqual(['vue'])
+})
+
+// #5727
+test('rewrite variable in string interpolation in function nested arguments', async () => {
+  const result = await ssrTransform(
+    `import { fn } from 'vue';function A({foo = \`test\${fn}\`} = {}){ return {}; }`,
+    null,
+    null
+  )
+  expect(result.code).toMatchInlineSnapshot(`
+    "const __vite_ssr_import_0__ = await __vite_ssr_import__(\\"vue\\");
+    function A({foo = \`test\${__vite_ssr_import_0__.fn}\`} = {}){ return {}; }"
+  `)
+  expect(result.deps).toEqual(['vue'])
+})
+
 test('do not rewrite when function declaration is in scope', async () => {
   const result = await ssrTransform(
     `import { fn } from 'vue';function A(){ function fn() {}; return { fn }; }`,

packages/vite/src/node/ssr/ssrTransform.ts

@@ -321,10 +321,12 @@ function walk(
                 !isStaticPropertyKey(child, parent) &&
                 // do not record if this is a default value
                 // assignment of a destructuring variable
-                !(
-                  parent &&
-                  parent.type === 'AssignmentPattern' &&
-                  parent.right === child
+                (
+                  !parent || 
+                  (
+                    !(parent.type === 'AssignmentPattern' && parent.right === child) &&
+                    !(parent.type === 'TemplateLiteral' && parent.expressions.includes(child))
+                  )
                 )
               ) {
                 setScope(node, child.name)
@@ -346,7 +348,12 @@ function walk(
                 setScope(parentFunction, (property.value as Identifier).name)
               }
             })
-          } else {
+          } else if (node.id.type === 'ArrayPattern') {
+            node.id.elements.forEach((element) => {
+              setScope(parentFunction, (element as Identifier).name)
+            })
+          }
+          else {
             setScope(parentFunction, (node.id as Identifier).name)
           }
         }