Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): let top-level this refer to globalThis #5312

Merged
merged 2 commits into from Oct 21, 2021
Merged

fix(build): let top-level this refer to globalThis #5312

merged 2 commits into from Oct 21, 2021

Commits on Oct 15, 2021

  1. fix: let top-level this refer to window 

    This prevents THIS_IS_UNDEFINED warning from Rollup when @babel/plugin-transform-react-jsx emits `jsx` calls that pass `this` inside an arrow function component, which in turn leads to SOURCEMAP_ERROR warnings, because the `this` reference doesn't exist in the original code.
    @aleclarson
    aleclarson committed Oct 15, 2021
    Copy the full SHA
    a7f4a61 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. fix: use globalThis 

    Co-authored-by: patak <matias.capeletto@gmail.com>
    @aleclarson @patak-dev
    aleclarson and patak-dev committed Oct 20, 2021
    Copy the full SHA
    4def2b6 View commit details
    Browse the repository at this point in the history