Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: minify css only when needed #5178

Merged
merged 4 commits into from Oct 23, 2021
Merged

perf: minify css only when needed #5178

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70eed35
perf: minify css only when needed
patak-dev Oct 2, 2021
2fe638a
fix: don't minify when not inlined
patak-dev Oct 2, 2021
7ef446d
refactor: simplify logic
patak-dev Oct 23, 2021
485da41
chore: spacing
patak-dev Oct 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/vite/src/node/plugins/css.ts
View file
Open in desktop
Expand Up @@ -55,8 +55,8 @@ export interface CSSOptions {
postcss?:
| string
| (Postcss.ProcessOptions & {
plugins?: Postcss.Plugin[]
})
plugins?: Postcss.Plugin[]
})
patak-dev marked this conversation as resolved.
Show resolved Hide resolved
}

export interface CSSModulesOptions {
Expand Down Expand Up @@ -311,15 +311,15 @@ export function cssPostPlugin(config: ResolvedConfig): Plugin {
// record css
if (!inlined) {
styles.set(id, css)
} else {
css = await minifyCSS(css, config)
}

return {
code:
modulesCode ||
(usedRE.test(id)
? `export default ${JSON.stringify(css)}`
? `export default ${JSON.stringify(
inlined ? await minifyCSS(css, config) : css
)}`
: `export default ''`),
map: { mappings: '' },
// avoid the css module from being tree-shaken so that we can retrieve
Expand Down