refactor: isCSSRequest for all css

[y1d7ng]

Description

#4127 (comment)

isCSSRequest is misleading. This can easily cause some bugs as people may using it without knowing that it explicitly tests for not being a direct request.

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[patak-dev]

I think we shouldn't use isIndirectCSSRequest here because at this point we don't know if it is direct or not. It would be more clear to me if we use isCSSRequest(url) && !isDirectRequest(url)
This should read as "is this a CSS Request that is not yet marked as direct?"

[patak-dev]

This PR is modifying some calls that we should review:

• "exclude css and static assets for performance", good to me

  vite/packages/vite/src/node/plugins/define.ts

  Line 71 in bd7c148

  isCSSRequest(id) ||

• Before, if there was a .css?direct URL it will not enter here. I think this change is ok
  

  vite/packages/vite/src/node/server/middlewares/transform.ts

  Line 139 in c90b7d9

  isCSSRequest(url) ||

• ok, direct dont reach here

  vite/packages/vite/src/node/plugins/importAnalysis.ts

  Line 52 in c45a02f

  return !isJSRequest(cleanUrl(url)) && !isCSSRequest(url)

• ok, direct dont reach here

  vite/packages/vite/src/node/plugins/html.ts

  Line 214 in 40c51e1

  if (node.tag === 'link' && isCSSRequest(url)) {

• ok, direct dont reach here

  vite/packages/vite/src/node/build.ts

  Line 589 in cb75dbd

  !isCSSRequest(id) &&

• ok, direct dont reach here

  vite/packages/vite/src/node/plugins/css.ts

  Line 320 in 690b35e

  !isCSSRequest(id) ||

@OneNail is this analysis correct? Would you help us with comments about why each of these changes is correct?

[patak-dev]

If isIndirectCSSRequest is not needed, this change ends up being just about removing the extra !directRequestRE.test(request) here

vite/packages/vite/src/node/plugins/css.ts

Line 105 in 690b35e

cssLangRE.test(request) && !directRequestRE.test(request)

That looks fine to me.

I wonder why it was added. It was part of the original commit that added the direct check.

[y1d7ng]

@patak-js Thank you very much for your review, I think your analysis is correct. So it seems that isIndirectCSSRequest is really not needed, I have removed it.

• The comment here indicate that this is to include all css
  

  vite/packages/vite/src/node/plugins/define.ts

  Lines 70 to 71 in bd7c148

  	// exclude css and static assets for performance
  	isCSSRequest(id) ||

• In the code block, both direct css and normal css will be processed
  

  vite/packages/vite/src/node/server/middlewares/transform.ts

  Line 139 in c90b7d9

  isCSSRequest(url) ||

  
  

  vite/packages/vite/src/node/server/middlewares/transform.ts

  Line 171 in c90b7d9

  const type = isDirectCSSRequest(url) ? 'css' : 'js'

• canSkip will filter out direct css
  

  vite/packages/vite/src/node/plugins/importAnalysis.ts

  Line 107 in c45a02f

  if (canSkip(importer)) {

  
  

  vite/packages/vite/src/node/plugins/importAnalysis.ts

  Line 488 in c45a02f

  if (!isCSSRequest(importer)) {

• Here is to process all css nodes in html
  

  vite/packages/vite/src/node/plugins/html.ts

  Line 214 in 40c51e1

  if (node.tag === 'link' && isCSSRequest(url)) {

• direct is added in the server mode, and will not appear in the build process under this design
  

  vite/packages/vite/src/node/build.ts

  Line 589 in cb75dbd

  !isCSSRequest(id) &&

  
  

  vite/packages/vite/src/node/plugins/css.ts

  Line 320 in 690b35e

  !isCSSRequest(id) ||

[patak-dev]

I think we should use a direct regex check here or maybe add a isDirectRequest(url) function to avoid repeating the CSS regex on every CSS file.

[y1d7ng]

I misunderstood it before and have changed it