Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade Rollup #4418

Closed
wants to merge 1 commit into from
Closed

Conversation

benmccann
Copy link
Collaborator

Description

Upgrade Rollup

Additional context

Vite is giving an incomprehensible warning message when building SvelteKit. This has been fixed in Rollup 2.46.0 (rollup/rollup#4054)


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@benmccann benmccann changed the title deps: Upgrade Rollup chore: Upgrade Rollup Jul 28, 2021
@benmccann
Copy link
Collaborator Author

Nevermind. It should already be grabbing a new version due to semantic versioning. I'll need more investigation

@benmccann benmccann closed this Jul 28, 2021
@benmccann benmccann deleted the upgrade-rollup branch July 28, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant