Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @vite/client http request is 404 not found #4187

Merged
merged 5 commits into from Aug 2, 2021

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented Jul 9, 2021

Description

fix issue #4174 (comment)

PR #4061 changed @vite/client to .mjs suffix

export const CLIENT_ENTRY = require.resolve('vite/dist/client/client.mjs')

If resolve.extensions is set, the vite will not ignore .mjs by default.

for (const ext of options.extensions || DEFAULT_EXTENSIONS) {
if (
(res = tryResolveFile(
file + ext,
postfix,
options,
false,
targetWeb,
options.tryPrefix
))
) {
return res
}
}

So @vite/client cannot find the file


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jul 9, 2021
@patak-dev patak-dev requested a review from sodatea July 9, 2021 09:25
@ygj6
Copy link
Member Author

ygj6 commented Jul 27, 2021

@sodatea help review, thank you

@antfu antfu merged commit 21ecdac into vitejs:main Aug 2, 2021
@tmkx tmkx mentioned this pull request Aug 23, 2021
6 tasks
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants