Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use rollup -w for dev bundling #4183

Merged
merged 1 commit into from Jul 12, 2021
Merged

build: use rollup -w for dev bundling #4183

merged 1 commit into from Jul 12, 2021

Conversation

sodatea
Copy link
Member

@sodatea sodatea commented Jul 9, 2021

Description

tsc does not support custom file extensions, which is used for the
emitted client files.

It does not understand the exports field of other packages,
making it impossible to use pure-ESM dependencies (#4059),

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sodatea
build: use rollup -w for dev bundling
cbc7f52 
`tsc` does not support custom file extensions, which is used for the
emitted client files.

It does not understand the `exports` field of other packages,
making it impossible to use pure-ESM dependencies (vitejs#4059),
@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jul 9, 2021
@Shinigami92
Copy link
Member

I will this declare as p2 for now. Sadly I don't have the knowhow to review the code 🙁

@sodatea sodatea mentioned this pull request Jul 10, 2021
Closed
6 tasks
@Shinigami92 Shinigami92 linked an issue Jul 10, 2021 that may be closed by this pull request
#4061 seems like break running vite in dev mode #4165
Closed
6 tasks
@sodatea sodatea requested a review from patak-dev July 12, 2021 05:19
@antfu antfu merged commit 25d86eb into vitejs:main Jul 12, 2021
@aleclarson
Copy link
Member

aleclarson commented Jul 26, 2021 •
edited

yarn dev doesn't produce type definitions anymore. @antfu Can this PR be reverted until a solution is found?

yarn build-types works, but doesn't have a watch mode

@patak-dev
Copy link
Member

@aleclarson we had to change this because dev was broken after these PRs #4063 and #4061, so there are like 4 commits to revert if we go that way. Maybe trying to fix the current setup is better here

@sodatea sodatea mentioned this pull request Jul 28, 2021
Merged
9 tasks
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@sodatea @aleclarson
build: use rollup -w for dev bundling (vitejs#4183)
c464906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

@patak-dev patak-dev Awaiting requested review from patak-dev

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#4061 seems like break running vite in dev mode
5 participants
@sodatea @Shinigami92 @aleclarson @patak-dev @antfu