Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve.extensions.length=0 is error, fix #4174 #4175

Closed
wants to merge 1 commit into from
Closed

fix: resolve.extensions.length=0 is error, fix #4174 #4175

wants to merge 1 commit into from

Conversation

jeff-fe
Copy link

@jeff-fe jeff-fe commented Jul 8, 2021

when resolve.extensions.length=0, DEFAULT_EXTENSIONS is not use

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

when resolve.extensions.length=0, DEFAULT_EXTENSIONS is not use
@jeff-fe jeff-fe marked this pull request as draft July 8, 2021 08:09
@jeff-fe jeff-fe marked this pull request as ready for review July 8, 2021 08:12
@Shinigami92
Copy link
Member

@patak-js Do we want a test case for this?

@patak-dev
Copy link
Member

If options.extensions is an empty array, no extensions should be resolved. Vite current behaviour is correct here. Pass undefined if you want to use the defaults

@patak-dev patak-dev closed this Jul 8, 2021
@jeff-fe
Copy link
Author

jeff-fe commented Jul 8, 2021

If options.extensions is an empty array, no extensions should be resolved. Vite current behaviour is correct here. Pass undefined if you want to use the defaults

hi @patak-js when options.extensions is an empty array, project page load error , @vite/client is 404 not found. please help to solve this problem. thanks.

image

@patak-dev
Copy link
Member

@ygj6 is already looking into this one #4174 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants