Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use .mjs extension for injected client modules #4061

Merged
merged 1 commit into from Jul 2, 2021
Merged

fix: use .mjs extension for injected client modules #4061

merged 1 commit into from Jul 2, 2021

Commits on Jul 1, 2021

  1. fix: use .mjs extension for injected client modules 

    Otherwise, they will not be recognized by Node.js as ES modules.

Usually it doesn't matter, as they're intended to run in browsers.

I only encountered this problem in `vite-jest`, which tries to run
vite-transpiled code in Node.js environments.
After this PR, the following hack would no longer be necessary:
https://github.com/sodatea/vite-jest/blob/1e05b4c62df714b1537c76052d5fec761a46c619/packages/vite-jest/bin/vite-jest.js#L11-L12
    @sodatea
    sodatea committed Jul 1, 2021
    Copy the full SHA
    da2d399 View commit details
    Browse the repository at this point in the history