Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip redirect and error fallback on middleware mode #4057

Merged
merged 4 commits into from Jul 2, 2021
Merged

fix: skip redirect and error fallback on middleware mode #4057

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
802875c
fix: skip redirect and error fallback on middleware mode
antfu Jun 30, 2021
5fe70fa
chore: typo
antfu Jun 30, 2021
a11db38
chore: update
antfu Jun 30, 2021
8342ae1
chore: try
antfu Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/vite/src/node/server/middlewares/base.ts
View file
Open in desktop
Expand Up @@ -19,7 +19,15 @@ export function baseMiddleware({
// rewrite url to remove base.. this ensures that other middleware does
// not need to consider base being prepended or not
req.url = url.replace(base, '/')
} else if (path === '/' || path === '/index.html') {
return next()
}

// skip redirect and error fallback on middleware mode, #4057
if (config.server.middlewareMode) {
return next()
}

if (path === '/' || path === '/index.html') {
// redirect root visit to based url
res.writeHead(302, {
Location: base
Expand Down