Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename type files as lowercase (fixes #4028) #4029

Closed
wants to merge 1 commit into from

Conversation

IanVS
Copy link
Contributor

@IanVS IanVS commented Jun 29, 2021

Description

This changes the files in vite/types to all be lowercase, so that they can be referenced in typescript triple-slash directives, which for some reason seem to always lowercase the provided path.

Additional context

I think it's likely a bug in typescript, but I don't think we can hold our breath on a change upstream, and this doesn't seem like a horrible workaround.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

I couldn't find a good way to write tests for this, but I did build and copy the results into my node_modules of my project, and verified that it solves the issue I was having.

@IanVS IanVS mentioned this pull request Jun 29, 2021
8 tasks
@IanVS
Copy link
Contributor Author

IanVS commented Jun 29, 2021

Replaced by #4031

@IanVS IanVS closed this Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant