Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update fsevents, chokidar, rollup #1901

Merged

Conversation

threepointone
Copy link
Contributor

@threepointone threepointone commented Feb 6, 2021

The installed version of fsevents, ~2.1.2 (2.1.3, to be precise) has issues with Apple M1 machines. So if you use vite to create an app, you'll get a warning vite > fsevents@2.1.3: "Please update to latest v2.3 or v2.2".

So, this PR updates fsevents to 2.3.1. chokidar also updated their usage of fsevents, so I updated chokidar as well to 3.5.1. Both these packages were already available transitively. rollup updated it's usage as well (via me, rollup/rollup#3945), so I updated rollup here too.

The installed version of `fsevents`, ~2.1.2 (2.1.3, to be precise) has issues with Apple M1 machines. So if you use `vite` to create an app, you'll get a warning `vite > fsevents@2.1.3: "Please update to latest v2.3 or v2.2"`.

So, this PR updates `fsevents` to 2.3.1. `chokidar` also updated their usage of `fsevents`, so I updated `chokidar` as well to 3.5.1. Both these packages were already available trasnitively. `rollup` updated it's usafe as well (via me, rollup/rollup#3945), so I updated `rollup` here too.
@yyx990803 yyx990803 merged commit 9726386 into vitejs:main Feb 8, 2021
@yyx990803
Copy link
Member

Thanks!

@threepointone threepointone deleted the update-fsevents-chokidar-rollup branch February 8, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants