docs: createViteRuntime should be imported from vite #16067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yuusheng
changed the title
sapphi-red
reviewed
Mar 1, 2024
sapphi-red
reviewed
Mar 1, 2024
docs/guide/ssr.md
Outdated
| @@ -134,7 +136,7 @@ app.use('*', async (req, res, next) => { | |||
| // It fully supports HMR and works in a simillar way to ssrLoadModule | |||
| // More advanced use case would be creating a runtime in a separate | |||
| // thread or even a different machine using ViteRuntime class | |||
| const runtime = await vite.createViteRuntime(server) | |||
| const runtime = await createViteRuntime(server) | |||
There was a problem hiding this comment.
I noticed that we shouldn't be creating createViteRuntime for every request I guess. @sheremet-va Does this work fine?
Maybe we should extract the ViteRuntime part and put a complete example in ::: details block.
There was a problem hiding this comment.
I think a complete example will definitely help a lot!
sheremet-va
approved these changes
Mar 26, 2024
|
By the way, this will be removed in 5.3 - #16089 |
|
Closing as we removed this section for now. Thanks for the PR 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix typo in Vite SSR documents.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).