fix: warn on missing optional peer deps during build #15737
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I wrote my findings in #15733 (comment) and it looks reasonable to treat this case similar to node builtin and log warning to notify users about potential issues with their build #12616
The node builtin warning happens during
resolveId
hook, but for missing peer dep, I added a warning duringload
hook since it looks simpler to implement in this way and probably there's no substantial difference for users.I haven't added a test but verified manually on playground by:
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).