Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use resolvePackageData in requireResolveFromRootWithFallback #12712

Conversation

sapphi-red
Copy link
Member

Description

This PR changes requireResolveFromRootWithFallback to use resolvePackageData instead of resolve.sync.

This function was introduced by ddfcbce and changed by #3988 and #10812.

Previously, this function was using require.resolve.paths and was passing this to resolve.sync and require.resolve. Now this function simply passes root and __dirname. IIUC this behaves same because

  • require.resolve.paths returns the value of NODE_MODULES_PATHS in this all together section
  • require.resolve uses paths option as a starting point for the module resolution algorithm. Also require.resolve always uses GLOBAL_FOLDERS. In other words, require.resolve will use paths.flatMap(p => NODE_MODULES_PATHS(p)) as candidates.

So passing root to paths option of require.resolve is same with passing createRequire(root).resolve.paths to paths option.

I tested this PR by the way written in #2612 and #10812.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Apr 3, 2023
@stackblitz
Copy link

stackblitz bot commented Apr 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit 1ea38e2 into vitejs:main Apr 5, 2023
12 checks passed
@sapphi-red sapphi-red deleted the refactor/require-resolve-from-root-with-fallback branch April 5, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants