-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: do not need <wbr> anymore #12234
Conversation
Run & review this pull request in StackBlitz Codeflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this is something that VitePress would want to have upstream, cc @kiaking
Nice idea! However, looks like VitePress did fix this issue and maybe you can simple remove We're handling this in our markdown parser and it should be working. FYI, Vite issue for this is currently open -> #5577 If it does not work, and if we need this css hack, not sure if we should add this to VitePress core to avoid adding unnecessary hacks as much as possible 馃 |
@kiaking I tested removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! I didn't know VitePress had fixed this natively. Looks like it's working: https://deploy-preview-12234--vite-docs-main.netlify.app/guide/api-javascript.html
A lot better like this! Thanks Kia for the tip |
Description
Currently, such as
process.env.
NODE_ENV = 'development'
in markdown is splitted into two parts which has redundant padding and border-radius, making the docs look weird. 馃槵before:
before.mp4
after:
after.mp4
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).