chore: ci: fix if check

[ArnaudBarre]

Re #11548
The condition did not work for #11638

This was way more complicated than I though. Really hard to make PR required checks behaves as expected when suing conditions.

Proposed solution:
See comment in the yml file. The issue with that is that is requires a transition period where require jobs will be off for old PRs. The advantage is that it will not happen later when we update node versions. This is the reason I opted for this solution.

Other solution:

  test-skip:
    needs: diff
    if: needs.diff.outputs.runTest == 'false'
    timeout-minutes: 1
    runs-on: ubuntu-latest
    strategy:
      matrix:
        os: [ubuntu-latest]
        node_version: [14, 16, 18]
        include:
          # Active LTS + other OS
          - os: macos-latest
            node_version: 18
          - os: windows-latest
            node_version: 18
    name: "Build&Test: node-${{ matrix.node_version }}, ${{ matrix.os }}"
    steps:
      - run: echo "No test required"

Other possibilities:

• Remove required check on test
• Split jobs, skip tests via path filtering and use dummy test job for requirement as suggested by the doc: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks
• Remove conditional run of test and make few PRs slower
• Remove conditional run of test and use nx

[dominikg]

hmm, this is getting a lot more complex than i thought it would. how does this look like in the final PR ui? if it just shows required with a red or green check and people have to click through, that would be worse.

I have used a similar trick before with always and manual state checks, but would prefer if we didn't have to resort to this. turning off required and a transition period are also not great.

Are there other options like turning build and test commands into a noop instead of outright skipping the job? kind of like a mini nx, not going the lengths of complex dependency and inputs configs, just skipping if docs is the only changed thing

[ArnaudBarre]

Yeah did that at the beginning and then though it would be cleaner to skip the job but yeah the final solution is worth that what i avoided at first. I will do that