Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: extend react-env timeout #11078

Merged
merged 1 commit into from Nov 25, 2022

Conversation

sapphi-red
Copy link
Member

Description

https://github.com/vitejs/vite/actions/runs/3549213538/jobs/5961324463#step:12:103
https://github.com/vitejs/vite/actions/runs/3549216206/jobs/5961330789#step:12:130
https://github.com/vitejs/vite/actions/runs/3549234201/jobs/5961371469#step:12:105

There were many fails by this timeout. I guess we could just remove this and use the default value (30 seconds).

refs #10861

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) test labels Nov 25, 2022
@patak-dev patak-dev merged commit b4da791 into vitejs:main Nov 25, 2022
@sapphi-red sapphi-red deleted the test/extend-react-env-timeout branch November 26, 2022 05:05
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority) test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants