Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import.meta.glob() string coercion in Svelte template #11051

Closed
wants to merge 1 commit into from
Closed

fix: import.meta.glob() string coercion in Svelte template #11051

wants to merge 1 commit into from

Conversation

janosh
Copy link

@janosh janosh commented Nov 23, 2022

Description

Closes #10949.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@janosh janosh changed the title Fix import.meta.glob() string coercion in Svelte template fix: import.meta.glob() string coercion in Svelte template Nov 23, 2022
@benmccann
Copy link
Collaborator

@janosh just making sure you've seen the CI failure:

Error: packages/vite build: src/node/plugins/importMetaGlob.ts(166,9): error TS2367: This condition will always return 'false' since the types '"CallExpression" | "NewExpression"' and '"BinaryExpression"' have no overlap.
Error: packages/vite build: src/node/plugins/importMetaGlob.ts(166,52): error TS2339: Property 'left' does not exist on type 'never'

@janosh
Copy link
Author

janosh commented Nov 24, 2022

Yeah sorry, thought I could finish this before work this morning. Will pick it up on weekend.

patak-dev pushed a commit that referenced this pull request Nov 28, 2022
patak-dev pushed a commit to vitejs/vite-plugin-react that referenced this pull request Dec 2, 2022
patak-dev pushed a commit to vitejs/vite-plugin-vue that referenced this pull request Dec 2, 2022
bluwy pushed a commit that referenced this pull request Dec 5, 2022
patak-dev pushed a commit that referenced this pull request Dec 5, 2022
* fix: glob import parsing (#10949) (#11056)

closes #10949
closes #11051

* fix: import.meta.env and process.env undefined variable replacement (fix #8663) (#10958)

Co-authored-by: bluwy <bjornlu.dev@gmail.com>
fix #8663

* fix(esbuild): handle inline sourcemap option (#11120)

* fix(importGlob): preserve line count for sourcemap (#11122)

* fix: Dev SSR dep optimization + respect optimizeDeps.include (#11123)

* fix: reset global regex before match (#11132)

* chore: fix test

Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
Co-authored-by: julienv3 <julienv3@gmail.com>
Co-authored-by: 翠 / green <green@sapphi.red>
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import.meta.glob breaks in Svelte template
2 participants