Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update import assertion config #11028

Merged
merged 1 commit into from Nov 22, 2022
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 22, 2022

Description

Import assertions in dependency now doesn't require prebundling in build to work, as Rollup 3 can safely parse import assertions and run Vite's default JSON handling.

Related #4934 (comment)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p1-chore Doesn't change code behavior (priority) label Nov 22, 2022
@patak-dev patak-dev enabled auto-merge (squash) November 22, 2022 04:51
@patak-dev patak-dev merged commit 1b1f633 into main Nov 22, 2022
@patak-dev patak-dev deleted the update-import-assertion-test branch November 22, 2022 05:04
fc pushed a commit to fc/vite that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants