Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update appType docs #11003

Merged
merged 2 commits into from Nov 20, 2022
Merged

docs: update appType docs #11003

merged 2 commits into from Nov 20, 2022

Conversation

benmccann
Copy link
Collaborator

Description

The same middlewares are included for both SPA and MPA mode, but you wouldn't necessarily conclude that from the docs currently. The only different is that in SPA mode the fallback middleware is configured with the spaFallback option

Additional context

Followup to #10985


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@benmccann benmccann added the documentation Improvements or additions to documentation label Nov 20, 2022
@patak-dev patak-dev merged commit a03860f into vitejs:main Nov 20, 2022
@patak-dev
Copy link
Member

Thanks!

fc pushed a commit to fc/vite that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants