Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(vue): reuse script ast for rewriting default #10888

Closed
wants to merge 1 commit into from
Closed

refactor(vue): reuse script ast for rewriting default #10888

wants to merge 1 commit into from

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Nov 12, 2022

vuejs/core#7068 (review)

Description

Reuse the AST and MagicString instance from resolveScript.

Please don't merge it until the upstream PR got merged and released.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sxzz sxzz marked this pull request as draft November 12, 2022 02:22
@sxzz sxzz closed this by deleting the head repository Jan 27, 2023
@sxzz sxzz reopened this Feb 4, 2023
@sxzz
Copy link
Member Author

sxzz commented Mar 9, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant