Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HMR on web/shared worker #10262

Closed
wants to merge 1 commit into from

Conversation

userquin
Copy link
Contributor

@userquin userquin commented Sep 27, 2022

Description

Fix client and overlay modules for HMR on web workers.

We need to fix using Worker/SharedWorker constructor and add a test for shared worker (worker url test included and tested with iife and es).

closes #5396

Additional context

NA


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@userquin userquin mentioned this pull request Sep 27, 2022
9 tasks
@bluwy
Copy link
Member

bluwy commented Sep 19, 2023

I'm cleaning up some stale PRs and it seems that this isn't ready yet for quite some time. Closing for now, but feel free to re-open a new PR!

@bluwy bluwy closed this Sep 19, 2023
@butzemannbiber
Copy link

Anything new about web worker support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR on service worker
3 participants