Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): conditionally self-accept fast-refresh HMR #10239

Merged
merged 8 commits into from Oct 5, 2022
Merged

fix(react): conditionally self-accept fast-refresh HMR #10239

merged 8 commits into from Oct 5, 2022
+160 −17

Commits on Sep 28, 2022

  1. test: add failing test

    @IanVS
    IanVS committed Sep 28, 2022
    Copy the full SHA
    d5e56a1 View commit details
    Browse the repository at this point in the history

  2. fix: conditionally accept if all exports are react components 

    But this is broken because Vite still treats this as self-accepting.
    @IanVS
    IanVS committed Sep 28, 2022
    Copy the full SHA
    46971d3 View commit details
    Browse the repository at this point in the history

  3. fix: always call hot.accept

    @aleclarson @IanVS
    aleclarson authored and IanVS committed Sep 28, 2022
    Copy the full SHA
    2c26991 View commit details
    Browse the repository at this point in the history

  4. fix: invalidate hmr if not boundary

    @IanVS
    IanVS committed Sep 28, 2022
    Copy the full SHA
    ce093e1 View commit details
    Browse the repository at this point in the history

  5. test: fix test expectation

    @IanVS
    IanVS committed Sep 28, 2022
    Copy the full SHA
    308421f View commit details
    Browse the repository at this point in the history

  6. test: add test for react context hmr

    @IanVS
    IanVS committed Sep 28, 2022
    Copy the full SHA
    7d5aa5d View commit details
    Browse the repository at this point in the history

  7. test: only run hmr tests in serve

    @IanVS
    IanVS committed Sep 28, 2022
    Copy the full SHA
    f2ec7b1 View commit details
    Browse the repository at this point in the history

  8. fix: move invalidate into accept callback

    @IanVS
    IanVS committed Sep 28, 2022
    Copy the full SHA
    535aa4f View commit details
    Browse the repository at this point in the history