Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky tests #10222

Merged
merged 1 commit into from Sep 23, 2022
Merged

test: fix flaky tests #10222

merged 1 commit into from Sep 23, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 23, 2022

Retry this test 3 times 馃槵

test('hmr', async () => {
// This is test is flaky in Mac CI, but can't be reproduced locally. Wait until
// network idle to avoid the issue. TODO: This may be caused by a bug when
// modifying a file while loading, we should remove this guard
await page.goto(url, { waitUntil: 'networkidle' })
editFile('src/pages/Home.vue', (code) => code.replace('Home', 'changed'))
await untilUpdated(() => page.textContent('h1'), 'changed')
})

We're not editing any files before that tests so I'm not sure what's causing the flakiness. I think it started after the dep upgrade PR: #10160

@bluwy bluwy added the test label Sep 23, 2022
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this one for now. cc @sapphi-red since you were checking the deps PR. I did re-run several times CI for it. Let's keep an eye on HMR and review this again before releasing 3.2

@patak-dev patak-dev merged commit 097fd57 into main Sep 23, 2022
@patak-dev patak-dev deleted the fix-flaky branch September 23, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants