fix(build): let top-level this refer to globalThis

[aleclarson]

Description

This prevents THIS_IS_UNDEFINED warning from Rollup when @babel/plugin-transform-react-jsx emits jsx calls that pass this inside an arrow function component, which in turn leads to SOURCEMAP_ERROR warnings, because the this reference doesn't exist in the original code.

An example Rollup warning message for SOURCEMAP_ERROR:

Error when using sourcemap for reporting an error: Can't resolve original location of error.

How code output is changed

This PR is especially important for @vitejs/plugin-react.

  return /* @__PURE__ */ jsxDevRuntime.exports.jsxDEV(Provider, {
    value: props,
    children
  }, void 0, false, {
    fileName: _jsxFileName$z,
    lineNumber: 42,
    columnNumber: 26
  }, this); // <== The problem

…becomes…

  return /* @__PURE__ */ jsxDevRuntime.exports.jsxDEV(Provider, {
    value: props,
    children
  }, void 0, false, {
    fileName: _jsxFileName$z,
    lineNumber: 42,
    columnNumber: 26
  }, window); // <== The solution

Workaround

Ignore the warning, or set rollupOptions.onwarn to handle it manually.

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

[aleclarson]

Hmm, I wonder if we should use "globalThis" in SSR env? @patak-js

[patak-dev]

@aleclarson I think we should use globalThis for non-legacy. It is supported from Node 12. The legacy plugin should take of transpiling it down to window when necessary, no?

[jordanamr]

Is there a way to silence this whilst waiting on this PR merge ? This is spamming my build logs with thousands of lines ahah

[aleclarson]

@jordanamr Set rollupOptions.context to "window" or "globalThis" in your Vite config

[antfu]

I would vote for globalThis

[genffy]

this fix cause anthoer issue, will convert inputPath with global keyword to gloalThis nuxt/nuxt#11958

[patak-dev]

Could you open a new issue so this csn be properly tracked?

[genffy]

Could you open a new issue so this csn be properly tracked?

sorry, comment metioned issue root casue is nuxt/bridge#204

[patak-dev]

If you think there is something to fix in Vite, please open an issue here

[aleclarson]

@genffy That issue is unrelated to this PR.