Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emptyOutDir): never remove .git #3043

Merged
merged 1 commit into from Apr 26, 2021

Conversation

aleclarson
Copy link
Member

@aleclarson aleclarson commented Apr 19, 2021

Description

If .git exists in the root of outDir, assume the user doesn't want it removed. The rationale is that Vite never generates .git for the user, so it should leave it alone.

This PR also contains a fix related to emptyOutDir when the --watch flag is used in build mode. Previously, the outDir would not be emptied before Rollup rebuilds if emptyOutDir was null. Now it is emptied.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

..and empty the out dir in `build --watch` mode when `emptyOutDir` is null.
@aleclarson aleclarson added the p3-minor-bug An edge case that only affects very specific usage (priority) label Apr 19, 2021
@patak-dev patak-dev requested a review from antfu April 19, 2021 07:20
@patak-dev patak-dev linked an issue Apr 20, 2021 that may be closed by this pull request
6 tasks
@patak-dev
Copy link
Member

See #3145 that also fixes this issue while replacing rollup watch with chokidar. We could still merge this fix though in the meantime.

@aleclarson aleclarson merged commit 82dc588 into vitejs:main Apr 26, 2021
@aleclarson aleclarson deleted the feat/emptyOutDir-git branch April 26, 2021 20:07
TobiasMelen pushed a commit to TobiasMelen/vite that referenced this pull request May 3, 2021
..and empty the out dir in `build --watch` mode when `emptyOutDir` is null.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vite build --watch should check emptyOutDir
2 participants