Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vite build --watch should check emptyOutDir #3068

Closed
6 tasks done
yunsii opened this issue Apr 20, 2021 · 3 comments · Fixed by #3043
Closed
6 tasks done

vite build --watch should check emptyOutDir #3068

yunsii opened this issue Apr 20, 2021 · 3 comments · Fixed by #3043
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)

Comments

@yunsii
Copy link

yunsii commented Apr 20, 2021

Describe the bug

emptyDir directly even if use emptyOutDir: false with vite build --watch. It will clear others resources not build by vite.

image

Reproduction

theprimone/violet@refactor/vite/package.json#L11

System Info

Output of npx envinfo --system --npmPackages vite,@vitejs/plugin-vue --binaries --browsers:

  System:
    OS: Linux 5.4 Ubuntu 18.04.5 LTS (Bionic Beaver)
    CPU: (12) x64 Intel(R) Core(TM) i7-10710U CPU @ 1.10GHz
    Memory: 10.98 GB / 12.33 GB
    Container: Yes
    Shell: 4.4.20 - /bin/bash
  Binaries:
    Node: 14.15.1 - /usr/local/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 6.14.8 - /usr/local/bin/npm
  npmPackages:
    vite: ^2.2.1 => 2.2.1 

Before submitting the issue, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Provide a description in this issue that describes the bug.
  • Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
  • Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
@patak-dev
Copy link
Member

Would you check if this PR: #3043 fixes your issue @theprimone ?

@patak-dev patak-dev added bug p3-minor-bug An edge case that only affects very specific usage (priority) and removed pending triage labels Apr 20, 2021
@yunsii
Copy link
Author

yunsii commented Apr 20, 2021

Would you check if this PR: #3043 fixes your issue @theprimone ?

Yes, it should be ok 🧐

@yunsii
Copy link
Author

yunsii commented Apr 27, 2021

Still not release...

@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
3 participants